Switch dev server + prod build to vite! #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Elijah Vennebush <[email protected]> Co-authored-by: Alex <[email protected]>
varCepheid
reviewed
Jan 1, 2024
There was a problem hiding this comment.
Works well on my machine! I'll wait to make sure it works on others as well, but mine is probably the oldest and slowest we're going to be using. The only issues I noticed were A. it's just very slow for some reason, and B. the icon doesn't load, although that doesn't really matter.
|
Works also on Pigmice's Lenovos (at least the one I'm typing this from, but the two are largely identical). Tested the login form and videos and nothing went wrong. I realized that I didn't try doing the production version on my home computer, so I'll try that soon. I'll leave it to @ev118 to approve. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
* Get vite to mostly work Co-authored-by: Elijah Vennebush <[email protected]> Co-authored-by: Alex <[email protected]> * Fix postcss config and delete more unused * Fix tests * Remove unused babel plugins * Adjust rollup config * Fix Service Worker and PWA stuff * Update to type:module in package.json * Undo needless change src -> @ * Undo more needless changes? * For now, undo linaria changes in all files * Remove unrelated change * Undo more changes * Remove more deps (will have to add back some of these) * Dep updates since last time I worked on this * Set up new version of linaria * Fix a silly CSS bug * Use port 2733 for preview as well * Fix TS imports * Increase min chunk size for chunk merging * Remove unmaintained postcss-font-magician * Update node LTS minimum * Replace Jest with Vitest for less config * Downgrade TS to avoid needing to update eslint-plugin-caleb in this PR * Remove unused old rollup config * Undo upgrading preact to avoid needing to fix type stuff in this PR * Re-update preact to fix integration with vite and prefresh * Fix chart where polished lib was included at runtime * Fix type errors * Use node 18 in CI * Delete commented code * Run prettier on html files too --------- Co-authored-by: Elijah Vennebush <[email protected]> Co-authored-by: Alex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wheeee!
Finally got this working! The first time I tried to switch this project over to vite was in 2019 when vite was first published. About every year since then, I've come back to this trying to get it to work but there have always been roadblocks (ehem, Linaria, Jest, ESM support...). Last year I got pretty close but now I had some time to finally get it across the finish line!
Before, we were using Webpack 4 (very old) for the dev server and Rollup for the production build. Now, we are using Vite for both (well, Vite uses Rollup under the hood for the build).
Sorry, this is a big PR, but it had to be. I didn't see any way to incrementally migrate the build system over.
Testing:
npm installnpm run devnpm installnpm run buildnpm run previewto startup a preview server of the production-built app